blumilksoftware / interns-2022c-internships

Intership programme application made by interns themselves.
MIT License
5 stars 5 forks source link

- Company form improvements and other adjustments #190

Closed sbanasiak closed 2 years ago

sbanasiak commented 2 years ago

Pull request mainly covers revamping the company creation form, changes the map library and fixes minor bugs.

Most important changes:

image image

image

sbanasiak commented 2 years ago
  1. I think that these buttons should be swapped. image
  2. For UX will be better to make confirmation a bit more informative. For now we have: image And maybe this text: "Usunąć firmę ? Nie można tego cofnąć" will be better?
  3. What is the difference between routes/and company/manage? I see the same list of companies.
  4. Why navigation is not highlighted when I'm on for example "Strona główna"?
  5. I don't like this button in create company form image and maybe this button "Zgłoś" should be on the last page?
  1. Personally, I think the order of the buttons is fine, but I changed apperance of the delete button. image
  2. Done. Now there is an additional information about the inability to undo delete action.
  3. Route '/' shows list of companies which we have permission to view, while 'company/manage' shows only companies that we can manage. Company account will only see the companies created by itself, and the administrator will see all companies.
  4. Navbar now shows the current sub-page and has been reworked to read items from JS array. image
  5. The appearance of the buttons for switching sections has been changed. The submit button is now in the last section. image
sbanasiak commented 2 years ago
  1. When I refresh the page I don't see selected language image
  2. In the console I see a lot of warnings regarding to not translated key, for example: image
  3. Do we really need to do this in .env file? image

1&2. This is a problem that requires more work, so it will be solved in a separate pull request.

  1. The settings have been removed from .env and a command has been created to make an administrator account: make:admin {email} {password} {name} {surname}.