blumilksoftware / interns-2022c-internships

Intership programme application made by interns themselves.
MIT License
5 stars 5 forks source link

#186 - Language detection and various fixes #195

Closed sbanasiak closed 1 year ago

sbanasiak commented 1 year ago

This pull request covers user language detection and various fixes. The next pull request is planned to include project documentation.

List of changes:

1. The user's language is now detected upon entering the site:

Closes #186

2. RWD when creating a company should now be better.

2. Company creating form has been rewritten and RWD is now better.

Before: image

After: image

New desktop view: image

Closes #194

3. Login/logout dropdown disappears as it should when clicked.

chrome_jtQcMNJcks Closes #191

4. Separated single GitHub Action into:

Closes #177

New changes since last review [Dec 6, 2022]:

5. Updated dependencies and cleaned out unnecessary packages.

6. Changed the default website font.

Preview: image

7. The appearance of the company's view has been slightly changed.

8. Changed navbar and added favicon.

Favicon has been added and the navbar's behavior has been changed - added subtle animations and now only the active page is underlined. image

sbanasiak commented 1 year ago
  1. Labels and validation errors are shouting at user: image Please change it to normal-case text.
  2. I know that I pick on, but I don't like text on this button. Maybe just "Dalej" for next step and "Wróć" or "Cofnij" image
  3. I think that this "Zalogowany jako" is unnecessary. image Name and surname will be enough and avatar icon maybe should be on the left side.
  4. Add some space here image
  1. They don't shout anymore.
  2. I think the text of the buttons is fine, they are quite large this way, and they are steps - each has a separate description, and all the steps must be completed correctly to submit the form.
  3. I removed "Zalogowany jako", and for now I will leave the icon as it is, on the left side it did not look too good.
  4. Done.