blumilksoftware / toby

HR software you love to hate
MIT License
17 stars 4 forks source link

Deleting confirmation dialog #233

Open EwelinaSkrzypacz opened 2 years ago

EwelinaSkrzypacz commented 2 years ago

Some resource can be deleted - benefits, CV, technologies, keys, holidays. It will be nice to add for them deleting confirmation dialog.

EwelinaSkrzypacz commented 1 year ago

After a research I think that we don't need confirmation modals itself. Confirmation dialogue modals appear after users take significant actions to ensure they are aware of the consequences.

In our application, the user (with right permissions) can delete benefits, CV, technologies, keys and holidays. Deleting these resources don't have big consequences - maybe accidentally deleting filled CV is sad, but only this.

Alternatively, some systems offer an "undo" feature instead of a confirmation, presented as a temporary notification that doesn't demand extra user attention. For instance, Google Gmail provides an undo option after deleting e-mail message.

image

And I think it will be great thing in the app. But it is harder that add modals, so it needs some vision how to implement this. So for now I leave this task for the future.