blumilksoftware / toby

HR software you love to hate
MIT License
17 stars 4 forks source link

#443 - employment, medical and ohs history #451

Closed kamilpiech97 closed 4 months ago

kamilpiech97 commented 5 months ago

Should close #443. Added option for administrator to manage users employment, medical exams and ohs trainings history. Added artisan toby:move-user-data-to-history command for migrate data about ohs training and medical exam into user history. Added tests.

Preview:

Screencast from 18-06-24 09:24:19.webm

kamilpiech97 commented 5 months ago
  1. Date format should be dd.mm.yyyy, we have now yyyy-mm-dd.

image

  1. Padding is too small - please look at other

image

Like here

image

  1. Please translate "type"

image

  1. We should add information that comment is optional.
  2. Can we make like automatic history? I mean, when user has changes date of for example medical exams, can we add automatically entry to history?
  1. FIxed but in #447, I added helper for that, I would use them here after merge.
  2. Added
  3. Added
  4. Added
  5. Removed that fields from user create/edit view after merge that PR, I should open PR with that #452
kamilpiech97 commented 5 months ago
  1. When I add history about ohv and I don't fill date to, I see error

image

  1. When I add information about employment, I can add employment form employment contract without date to, but in other cases I can't. Is it by purpose?
  1. fixed
  2. Yep, it's conditionally.
kamilpiech97 commented 5 months ago

Why I see this? I believe that was for debugging and now it should be removed ;)

image

EDIT:

Validation messages are not consistent

image

fixed :DDD