wacker.py: Add event handling for missing network, fix shebang

blunderbuss-wctf / wacker

A WPA3 dictionary cracker

BSD 2-Clause "Simplified" License

290 stars 54 forks source link

wacker.py: Add event handling for missing network, fix shebang #3

Closed foxtrot closed 3 years ago

foxtrot commented 3 years ago

Small quality of life improvement to prevent the program from "hanging" if the network isn't found.
All systems I've used have python3 (as a symlink to python3.7, or 3.8, etc). The current way will break on systems with newer versions.

rpcraig commented 3 years ago

LGTM I think I'm still gonna add a 3.7+ check in the code though. So maybe something akin to assert sys.version_info >= (3,7)

rpcraig commented 3 years ago

Actually, by returning the Wacker.FAILURE status code we would then just be retrying the next word in the wordlist. Was that your intention? Or would you just want the Wacker.RETRY status code returned which will retry with the same word. Or maybe a new status code like Wacker.EXIT in case we shouldn't retry at all?

foxtrot commented 3 years ago

Ah, that's my mistake then. The intention is to abandon the brute-force if the network isn't found. I think your suggestion about something like Wacker.EXIT would be good then. I can implement that in this PR if you like?

rpcraig commented 3 years ago

Yes, please. Could you also incorporate the assert sys.version_info >= (3,7) right beneath the imports as well?

foxtrot commented 3 years ago

Should be good, seems to work in my testing.