search

blupi-games / planetblupi

Planet Blupi source code
https://www.blupi.org
Other
86 stars 22 forks source link

Mallet sound effect is a bit off when Blupi hits it downwards. The sticky trap also doesn't have a sound anymore. #104

Closed omarogi35 closed 1 year ago

omarogi35 commented 2 years ago

So when Blupi is hitting the mallet downwards, (usually on teleporters and incubators) it makes the noise still, but it isn't as accurate as it used to be. Like when he hits it down twice in a row, the sound of the mallet can only be heard once instead of twice. I also noticed that the sticky trap doesn't make the sound effect when an enemy becomes trapped.

Skywalker13 commented 1 year ago

Thanks for the report...

Skywalker13 commented 1 year ago

I identified the regression; it's when I've replaced the whole DirectSound stuff by SDL_mixer. I decided to play a channel only if this channel was not already playing. Then, when a specific sound is longer that the animation, it's not stopped (rewarded) if the animation wants this sound again. The original implementation, just stop it and start again. I can restore this behaviour very easily.

Not sure about that..

Skywalker13 commented 1 year ago

Mmmmh.. In the original it's a bit different.. the same problem appears when the speed is changed to 2x for example. It's not very good.. maybe I can improve it with a fade..

Skywalker13 commented 1 year ago

I fixed the regression with the sticky trap.

Skywalker13 commented 1 year ago

Now it's fine for the normal speed (1x). With the speed (2x) there are a lot of other problems because it's not possible to have something accurate in this case. At least, not with the current engine.