search

bluppfisk / coindicator

A crypto-currency (Bitcoin, Ethereum et al) market price indicator for the Linux desktop. Sits in the tray and lets you set alerts. Supports GNOME, Unity and KDE.
MIT License
160 stars 40 forks source link

Custom conversion #41

Open dcam0050 opened 6 years ago

dcam0050 commented 6 years ago

Say you have the ticker price for eth to usd and that for another cryptocurrency to eth, would it be possible to add a feature to convert the other cryptocurrency to usd?

bluppfisk commented 6 years ago

hello Daniel, not sure what you mean?

dcam0050 commented 6 years ago

As an example say I want the price of Nebl in USD but Nebl is only available as Nebl / ETH is there a way I can chain 2 exchanges together Nebl / ETH and ETH/USD to get Nebl/USD in the indicator?

On 14 March 2018 at 08:10, bluppfisk notifications@github.com wrote:

hello Daniel, not sure what you mean?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nilgradisnik/coinprice-indicator/issues/41#issuecomment-372937060, or mute the thread https://github.com/notifications/unsubscribe-auth/AEFwFx9hjpHrCV30TBf6MFy5j9S0lNjlks5teNBlgaJpZM4Sp-ud .

bluppfisk commented 6 years ago

Hi Daniel that makes sense. I'll implement it when I have some time (which may not be in the next 2 weeks).

bluppfisk commented 6 years ago

Note to self:

This requires rewriting the exchange class to be less tightly coupled to the indicator class, so that the exchange class has control over the number of API requests sent. Some APIs will ban the client if there are too many requests (e.g. when additional requests are necessary to convert BTC -> USD in order to figure out what a more obscure coin in USD is).