Fix spline data memory leak

RDelet commented 2 months ago

Checklist

[x] I have read the CONTRIBUTING.md document
[x] I formatted my changes with black
[x] I linted my changes with flake8
[ ] I have added documentation regarding my changes where necessary
[x] Any pre-existing tests continue to pass
[ ] Additional tests were made covering my changes

Types of Changes

[x] Bugfix (change that fixes an issue)
[ ] New Feature (change that adds functionality)
[ ] Documentation Update (if none of the other choices apply)

Proposed Changes

CLAassistant commented 2 months ago

All committers have signed the CLA.

tbttfox commented 3 weeks ago

Hey, sorry it took me a month and a half to get back to you. Production happens.

This looks good. Thanks for taking the time to help out! Probably worth removing line 46 as x is no longer used. I'll do that before I make a release.

RDelet commented 1 week ago

Hi Taylor,

Sorry for my late response too, I was on vacation and then I had a lot of work to catch up on.

Thank you very much for your review. Indeed I completely forgot to delete this line of code, plus I had seen it... Sorry !

Best regards,

Le mar. 22 oct. 2024 à 20:23, Tyler Fox @.***> a écrit :

Merged #39 https://github.com/blurstudio/TwistSpline/pull/39 into master.

— Reply to this email directly, view it on GitHub https://github.com/blurstudio/TwistSpline/pull/39#event-14790547678, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXWIXIL6OB2CF6QPGKPO5DZ42J3NAVCNFSM6AAAAABOKRENVOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUG44TANJUG43DOOA . You are receiving this because you authored the thread.Message ID: @.***>

-- Rémi Deletrain. CG Artist, character TD. http://remideletrain.wix.com/remi-deletrain http://remideletrain.wix.com/remi-deletrain

blurstudio / TwistSpline