search

blurymind / YarnClassic

A tool for writing interactive dialogue in games!
MIT License
514 stars 51 forks source link

[CLOSED] yarn - electron - lots of new features #80

Closed desplesda closed 5 years ago

desplesda commented 5 years ago

Issue by blurymind Sunday Sep 02, 2018 at 19:28 GMT Originally opened as https://github.com/InfiniteAmmoInc/Yarn/pull/80

This also adds the feature of showing tags and title of active nodes: bondagejsnodedata2

As well as fixes some code that can make easier to embed in other electron software

Tags and node titles can be used to trigger events in game, such as change of avatars or animations during cutscenes

Also updating bondage.js after I made some changes: https://github.com/jhayley/bondage.js/pull/39#issuecomment-417941721 https://github.com/jhayley/bondage.js/pull/40 https://github.com/jhayley/bondage.js/pull/41

you can download a build here btw: https://github.com/blurymind/Yarn/releases/tag/v0.3.2 (outdated build)

added after build:

blurymind included the following code: https://github.com/InfiniteAmmoInc/Yarn/pull/80/commits

desplesda commented 5 years ago

Comment by blurymind Monday Sep 03, 2018 at 08:27 GMT

@charblar and @julsam requested me to unbeautify the code, which I ran beautify on in a previous commit

-That is included in this pull request

desplesda commented 5 years ago

Comment by blurymind Friday Nov 23, 2018 at 21:29 GMT

@charblar can you review this please? I added some new features, merged changes from master/electron (here), updated bondage.js to the latest version

desplesda commented 5 years ago

Comment by blurymind Friday Nov 23, 2018 at 22:01 GMT

you can download a build here btw: https://github.com/blurymind/Yarn/releases/tag/v0.3.2

the linux build hasnt been tested and was cross compiled

desplesda commented 5 years ago

Comment by blurymind Saturday Nov 24, 2018 at 10:27 GMT

fixed #78

desplesda commented 5 years ago

Comment by blurymind Saturday Nov 24, 2018 at 10:56 GMT

fixed #83

desplesda commented 5 years ago

Comment by blurymind Saturday Nov 24, 2018 at 14:51 GMT

reverted fix for #78 as it is already in another pull here: #79

desplesda commented 5 years ago

Comment by blurymind Wednesday Nov 28, 2018 at 22:13 GMT

added new bbcode and [[ autocompletion features + bb format preview features

desplesda commented 5 years ago

Comment by blurymind Thursday Nov 29, 2018 at 20:45 GMT

added editor preview bbcode mode, still needs a few small fixes before its ready

desplesda commented 5 years ago

Comment by blurymind Friday Nov 30, 2018 at 20:09 GMT

added optional spell checking - exposing it to the user. Had to make a few changes to: https://github.com/swenson/ace_spell_check_js/pull/3 in order to get it to also be able to disable spell checking

desplesda commented 5 years ago

Comment by blurymind Friday Nov 30, 2018 at 21:10 GMT

added a demo to youtube. See it here https://www.youtube.com/watch?v=Cyr8nbjDxB4

@charblar look at these sweet new features :p why you not review

desplesda commented 5 years ago

Comment by blurymind Tuesday Dec 04, 2018 at 21:23 GMT

Added a color picker for bbcode fonts (using the spectrum.js)

ezgif com-optimize

desplesda commented 5 years ago

Comment by blurymind Wednesday Dec 05, 2018 at 19:24 GMT

Preview mode now has the same scroll position as ace editor. It also has a row counter

desplesda commented 5 years ago

Comment by blurymind Thursday Dec 06, 2018 at 22:28 GMT

I added a bbcode toolbar, moved the counter to preserve vertical space, check it out

desplesda commented 5 years ago

Comment by blurymind Thursday Dec 06, 2018 at 22:49 GMT

I need to fix the '#' making text after greyed - my suspicion is that this is part of the ace editor theme settings somewhere. Need to also move the addlink menu to the toolbar as well as add command tagging <<>>

desplesda commented 5 years ago

Comment by blurymind Saturday Dec 08, 2018 at 20:41 GMT

fixed the annoying greying out after hashtags, added a context menu to the editor as well as autocompletion of common words and suggestions for any misspelled words

desplesda commented 5 years ago

Comment by blurymind Monday Dec 10, 2018 at 18:22 GMT

Added night mode to the editor. Toggling it will invert all the light colors which the editor currently uses

desplesda commented 5 years ago

Comment by blurymind Wednesday Dec 12, 2018 at 12:54 GMT

desplesda commented 5 years ago

Comment by blurymind Wednesday Dec 12, 2018 at 20:55 GMT

replaced typo.js with nspell -as typo.js hasnt seen an update in over 3 years, it has a serious delay on some word suggestions and is much less maintained. Made pull here too https://github.com/swenson/ace_spell_check_js/pull/4

desplesda commented 5 years ago

Comment by blurymind Saturday Dec 15, 2018 at 01:16 GMT

I think I'm getting closer to a milestone on this. Will do a bit of re-factoring and testing, then do another build

desplesda commented 5 years ago

Comment by blurymind Saturday Jan 19, 2019 at 20:29 GMT

well anyways, if nobody is maintaining this repository, I might have to make my fork of this project a new project. :)

@julsam has added node resizing and fixed a bug, so I want to get his changes into my fork, but his pull is still not being reviewed either

desplesda commented 5 years ago

Comment by desplesda Saturday Jan 19, 2019 at 23:15 GMT

I’ll review this in the next 48h!

desplesda commented 5 years ago

Comment by desplesda Monday Jan 21, 2019 at 09:29 GMT

This is really, really good.

When should we consider merging this into master?

desplesda commented 5 years ago

Comment by blurymind Monday Jan 21, 2019 at 12:39 GMT

Thank you! I will also upload a portable electron version soon, so people won't have to build it to try it =)

On Mon, Jan 21, 2019, 9:29 AM Jon Manning <notifications@github.com wrote:

Merged #80 https://github.com/InfiniteAmmoInc/Yarn/pull/80 into electron.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/InfiniteAmmoInc/Yarn/pull/80#event-2085852104, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMbVaIZM6ThmkXvla0WD-Xzu9lXylZNks5vFYiHgaJpZM4WWu-s .

desplesda commented 5 years ago

Comment by desplesda Monday Jan 21, 2019 at 12:49 GMT

Something that we should discuss soon is setting up a CI server of some kind to automate the builds. Travis CI has worked well for Yarn Spinner.

desplesda commented 5 years ago

Comment by lazerwalker Monday Jan 21, 2019 at 19:59 GMT

Just to chime in on the CI server front, this is something I'm dealing with right now for https://github.com/lazerwalker/tracery-dot-app.

For Windows builds, you want Appveyor or Azure Pipelines; Travis CI's Windows setup is slow and flaky. You can check out Tracery.app's Appveyor config file, although my deployment setup is a bit different from yours since I'm using electron-forge/electron-builder to manage that instead of vanilla Electron. It's set up really nicely to automatically upload a new prerelease binary to the GitHub 'releases' section of the repo every time code is pushed/merged.

I'm still figuring out how to properly generate macOS builds on CI (since you ideally need to both codesign and notarize builds to avoid users needing to jump through onerous "this app is dangerous!" security hoops), but the data I've gathered so far suggests CircleCI is going to be the simplest way to configure a CI setup that can properly codesign/notarize given proper credentials.

desplesda commented 5 years ago

Comment by blurymind Monday Jan 21, 2019 at 20:20 GMT

I made some builds here, but they are only for windows https://github.com/blurymind/Yarn/releases/tag/0.3.5

server builds would be fantastic to have!