search

bluss / matrixmultiply

General matrix multiplication of f32 and f64 matrices in Rust. Supports matrices with general strides.
https://docs.rs/matrixmultiply/
Apache License 2.0
213 stars 25 forks source link

Remove space from file names #78

Closed xander-zitara closed 1 year ago

xander-zitara commented 1 year ago

The space introduced with the addition of the spare kernels directory breaks Rust builds in Bazel (which doesn't like spaces!) for any project depending transitively on matrixmultiply. I have replaced the space in spare kernels (making it spare_kernels) to fix this problem, and confirmed that this crate builds and tests pass.

Fixes #79

bluss commented 1 year ago

Do you know why a modern tool has such strange restrictions, and who uses Bazel?

xander-zitara commented 1 year ago

Do you know why a modern tool has such strange restrictions, and who uses Bazel?

Bazel is somewhat common for large projects that use multiple languages (imagine some code base with any combination of Rust, C++, Go, Java) in my experience. I don't know the reason for the restriction.

bluss commented 1 year ago

Thanks. I'll squash merge this to clean up the history. And make a note that Bazel is quirky.

v 0.3.7 released