Closed schneiderfelipe closed 6 months ago
That sounds nice. Are you interested in becoming a maintainer for the crate?
That sounds nice. Are you interested in becoming a maintainer for the crate?
Sure!
This crate hasn't gotten any love in a long time, unfortunately. Maybe a bump to 0.3 is appropriate with all the updates (?)
I unfortunately haven't had the bandwidth for all the crates I created long time ago (:sweat_smile:). The risk is that I'd like to give the crate away, but maybe it's best to share maintainership?
This crate hasn't gotten any love in a long time, unfortunately. Maybe a bump to 0.3 is appropriate with all the updates (?)
Done!
I unfortunately haven't had the bandwidth for all the crates I created long time ago (:sweat_smile:). The risk is that I'd like to give the crate away, but maybe it's best to share maintainership?
I'm glad to contribute! Maybe we could discuss what to do with #8 and #10 after this PR?
Ok so #8 is harder than I thought.
Is it Ok if I merge this?
@schneiderfelipe yes, thanks for doing this. In general feel free to do what you think is best as maintainer, better to be bold than do nothing.
Hi @bluss, here I propose some small changes:
No version has been bumped.
I haven't observed any significant performance changes.
Now (adadf78): ``` test heap_iterative_7 ... bench: 17,639 ns/iter (+/- 376) test heap_iterative_7_iter ... bench: 16,231 ns/iter (+/- 558) test heap_recursive_7 ... bench: 7,119 ns/iter (+/- 558) ``` Before (afdb943): ``` test heap_iterative_7 ... bench: 17,629 ns/iter (+/- 500) test heap_iterative_7_iter ... bench: 16,313 ns/iter (+/- 495) test heap_recursive_7 ... bench: 7,062 ns/iter (+/- 311) ```With those changes, the MSRV becomes 1.56.1.
```console $ cargo msrv Fetching index Determining the Minimum Supported Rust Version (MSRV) for toolchain x86_64-unknown-linux-gnu Using check command cargo check Check for toolchain '1.66.1-x86_64-unknown-linux-gnu' succeeded Check for toolchain '1.61.0-x86_64-unknown-linux-gnu' succeeded Check for toolchain '1.58.1-x86_64-unknown-linux-gnu' succeeded Check for toolchain '1.57.0-x86_64-unknown-linux-gnu' succeeded Check for toolchain '1.56.1-x86_64-unknown-linux-gnu' succeeded Finished The MSRV is: 1.56.1 ███████████████████████████████████████████████████████████████████ 00:00:02 ```