blutorange / closure-compiler-maven-plugin

Combine and minimize JavaScript with Closure Compiler.
http://blutorange.github.com/closure-compiler-maven-plugin
Apache License 2.0
52 stars 6 forks source link

Why webappSourceDir and cssSourceDir? #13

Closed blutorange closed 5 years ago

blutorange commented 5 years ago

Issue by aibar Tuesday Jan 19, 2016 at 12:05 GMT Originally opened as https://github.com/samaxes/minify-maven-plugin/issues/115


It's confusing. Why not only cssSourceDir and default value for it "${basedir}/src/main/webapp/css". In our project we have separate module for styles, it's not webapp and webappSourceDir is meaningless. And for target it's the same, we have webappTargetDir and relative cssTargetDir.

blutorange commented 5 years ago

Comment by madisparn Wednesday Jan 20, 2016 at 20:59 GMT


The actual css directory used by the plugin is ${webappSourceDir} + '/' + ${cssSourceDir}, and the default for ${cssSourceDir} is 'css', as for ${webappSourceDir} the default is also resonable '${basedir}/src/main/webapp', so in your case thos properies can not be specified in pom.xml

blutorange commented 5 years ago

Comment by aibar Tuesday Feb 02, 2016 at 12:38 GMT


It's clear to me and I am not building webapp (no maven-war-plugin).

Plugin is configured to be used with maven-war-plugin. Probably many users will use plugin in their war projects, but it's not always true.

blutorange commented 5 years ago

Comment by samaxes Thursday Oct 27, 2016 at 23:10 GMT


The reasoning being this choice was that for the vast majority of cases you don't need to change webappSourceDir. And if you want to use styles instead of css for the cssSourceDir, just changing that specific folder name is easier than having to define the entire path. Of course, this means that for less common scenarios you need to define both options in the plugin configuration. I'm not sure which one is the better solution, but i'm slightly inclined to leave it as it is unless there are more arguments against it.

blutorange commented 5 years ago

Comment by aibar Friday Oct 28, 2016 at 14:33 GMT


Simply, I would leave only cssSourceDir. Typing entire path once isn't hard. No other arguments. If you don't see the sense, you can can close the issue.

blutorange commented 5 years ago

Comment by DylanVRRandall Tuesday Dec 20, 2016 at 09:52 GMT


Something like what aibar said would prove useful to me.

blutorange commented 5 years ago

webappSourceDir / webappTargetDir is now baseSourceDir / baseTargetDir. sourceDir and baseDir are then relative to this directory.

This allows setting the base dir once, and the sourceDir / targetDir separately for each aggregation / bundle / execution