search

blutorange / closure-compiler-maven-plugin

Combine and minimize JavaScript with Closure Compiler.
http://blutorange.github.com/closure-compiler-maven-plugin
Apache License 2.0
52 stars 6 forks source link

closureLanguageOut ECMASCRIPT5 should not enforce STRICT mode #19

Closed blutorange closed 2 years ago

blutorange commented 6 years ago

Issue by ph3n0m666 Tuesday Mar 21, 2017 at 10:31 GMT Originally opened as https://github.com/samaxes/minify-maven-plugin/issues/138

It seems, using 1.7.6 specifying ECMASCRIPT5 in closureLanguageIn/closureLanguageOut, is returning the following

object literals cannot contain duplicate keys in ES5 strict mode - but I am not specifying ECMASCRIPT5_STRICT - only ECMASCRIPT5

blutorange commented 6 years ago

Comment by cqxxxxxxxx Tuesday May 09, 2017 at 13:43 GMT

this cames to me too. how you fix this?

blutorange commented 6 years ago

Comment by ph3n0m666 Tuesday May 09, 2017 at 13:57 GMT

Have not been able to fix this yet, still an open issue for me

blutorange commented 6 years ago

Comment by rtomsick Tuesday Jun 26, 2018 at 18:14 GMT

Still there, still a bug.

This project is pretty much abandoned, right?

blutorange commented 6 years ago

This is a wrapper for closure compiler. This seems to be an issue with closure compiler itself. I can reproduce with the command line of closure compiler, even when disabling errors:

java -jar closure-compiler-v20181008.jar --language_in ECMASCRIPT_2016 --language_out ECMASCRIPT3 /tmp/test.js --jscomp_off es5Strict
nitehawk42 commented 4 years ago

Is there a non-abandoned maven plugin project for closure-compiler?

blutorange commented 4 years ago

@nitehawk42 What do you mean? I'm still working on this plugin, although currently there's not much more to do than ocassionally updating closure compiler to the latest version. If there's a new closure compiler you need quickly, feel free to tell me and I can release a new version of this plugin. As for this issue, I kept it open, but the behavior is how closure compiler works.

blutorange commented 2 years ago

Closing as this is an issue of closure compiler itself (which may or may not have been changed in the recent version of closure compiler).