search

blutorange / closure-compiler-maven-plugin

Combine and minimize JavaScript with Closure Compiler.
http://blutorange.github.com/closure-compiler-maven-plugin
Apache License 2.0
52 stars 6 forks source link

Issue in merging java-script source files in a particular order #27

Closed blutorange closed 5 years ago

blutorange commented 5 years ago

Issue by kannan08 Friday May 19, 2017 at 07:16 GMT Originally opened as https://github.com/samaxes/minify-maven-plugin/issues/146


<jsSourceIncludes>
                                    <jsSourceInclude>UIApp.js</jsSourceInclude>
                                    <jsSourceInclude>UIApp.run.js</jsSourceInclude>
                                    <jsSourceInclude>UI-i18n.config.js</jsSourceInclude>
                                    <jsSourceInclude>UI-router-helper.provider.js</jsSourceInclude>
 <jsSourceInclude>aa/nnn/r.js</jsSourceInclude>
 <jsSourceInclude>aa/nnn/a.js</jsSourceInclude>
<jsSourceIncludes>
We need it should merge what order we mention in the <jsSourceInclude> but it always short by fileName
blutorange commented 5 years ago

Comment by twothe Wednesday Jan 17, 2018 at 15:03 GMT

The fact that this plugin merges files in the order of file-name makes it completely unusable in modern web environment. If JS file A needs to access JS library B, it won't work, cause B comes after A.

This plugin absolutely needs a way to define the order of files.

blutorange commented 5 years ago

Comment by scarballo Tuesday Jun 19, 2018 at 10:11 GMT

I think that order JS files by file name suppose a big problem when merge them. The plugin should keep the original order to make it usable as @kannan08 said. Is this possible?

blutorange commented 5 years ago

Comment by blutorange Saturday Oct 13, 2018 at 13:52 GMT

You should be able to use

<jsSourceFiles>
    <jsSourceFile>zzz.js</jsSourceFile>
    <jsSourceFile>aa.js</jsSourceFile>
</jsSourceFiles>

instead of jsSourceInclude. This should preserve the order.

blutorange commented 5 years ago

See https://github.com/blutorange/closure-compiler-maven-plugin/issues/6