bluwy / create-vite-extra

Extra Vite templates
MIT License
370 stars 55 forks source link

Improve Deno templates #35

Closed devmattrick closed 1 year ago

devmattrick commented 1 year ago

This includes a couple of improvements for the Deno templates:

I tried using import maps for the latter but it doesn't seem to work (potentially related bug here: denoland/deno#13009). Let me know if you'd like any changes to be made, thanks!

bluwy commented 1 year ago

Thanks! The first change make sense to me. I'm not so sure about the second one though, how are you configuring the Deno extension in your IDE locally? I never quite understood the right configuration, but presumably it only has to check the vite.config.mts file 🤔

devmattrick commented 1 year ago

Hmm that's a good point. I had my IDE setup to just enable Deno for the whole workspace, but I guess Vite doesn't do Deno-style module resolution? Or I'm honestly not entirely sure how that works...

bluwy commented 1 year ago

Yeah. If I enable Deno entirely, I'm getting a lot of resolution errors for files that Vite processes. In VSCode, I setup the settings with deno.enablePaths: ['./vite.config.mts'] (not sure if this is recommended).

Maybe we can remove that change for now, and keep the .vite gitignore change. In a later PR we can add some default configs for the Deno extension.

devmattrick commented 1 year ago

Sounds good! Done.