search

bluwy / create-vite-extra

Extra Vite templates
Other
391 stars 62 forks source link

feat: add `ssr-vue2` and `ssr-vue2-ts` templates #42

Closed pratik149 closed 10 months ago

pratik149 commented 10 months ago

Thank you @bluwy for this project!

I have added the following Vue 2 SSR templates by cloning existing Vue 3 templates, and made necessary changes into them.

  1. template-ssr-vue2
  2. template-ssr-vue2-ts

Tested the dev, build, preview cmds in both new templates using PNPM 8.13.1, NPM 9.6.7 and Node 18.17.1

vite-vue2 vite-vue2-ts

bluwy commented 10 months ago

Thanks for the PR! I wonder though isn't Vue 2 already deprecated? It's also going to be EOL in a few days. In which I'm not sure to create the templates to encourage further use of it.

pratik149 commented 10 months ago

Ah yes, you are right about Vue 2 coming to EOL and the reason to not include them in these templates.

I just created a PR because I was unable to find any example of Vue2+Vite SSR template/boilerplate on the internet, and I needed it in one of my project where Vue 2 is being used extensively, and upgrading to Vue 3 is not feasible enough. Thought there would few more people like me.

But I let it up for you to decide. If this doesn't get merge, then I will probably create a separate boilerplate repo. :)

bluwy commented 10 months ago

Yeah I think the best way for create-vite-extra is to avoid this for now. Feel free to create a new repo for the templates! I'll close this then.