Closed Ibadichan closed 6 months ago
Thanks for opening a PR. I'm not able to do a proper review to test it locally as I'll be away for the next week, but I'll make sure to do so when I return.
From a glance, I think I'd prefer adding a streaming specific template like https://github.com/bluwy/create-vite-extra/pull/46 (for Vue), so that users can choose between both. Ideally the code pattern should look as close as possible to that PR so that the templates are consistent.
Ok, i will try to create similar template, thanks.
Hi @bluwy, please check new react templates. https://github.com/bluwy/create-vite-extra/pull/54.
Using current react ssr template lazy loading does not work because
renderToString
does not supportSuspense
on server. We can userenderToPipeableStream
and listen foronAllReady
callback to "simulate"renderToString
behavior.https://github.com/bluwy/create-vite-extra/pull/50