bluwy / create-vite-extra

Extra Vite templates
MIT License
370 stars 55 forks source link

Cannot build the deno-lit template #7

Closed gmosx closed 1 year ago

gmosx commented 1 year ago

Thank you for providing the deno-lit template.

I would like to report an issue though. When I am trying to build the example, with:

deno task built

I get:

Name in package.json is required if option "build.lib.fileName" is not provided.
error during build:
Error: Name in package.json is required if option "build.lib.fileName" is not provided.
bluwy commented 1 year ago

Ah looks like that option would be required in Vite as Deno doesn't have package.json. Adding that one.

gmosx commented 1 year ago

Thanks for the quick response.

However, now deno task serve doesn't seem to be working, seems an app.mjs files is generated instead of index.html etc.

bluwy commented 1 year ago

Oh ya lit projects with vite don't really have a serve or preview command as it's using Vite's library mode feature. I guess we should remove that to avoid confusion. Here's Vite's template too: https://github.com/vitejs/vite/blob/7c4accb8dec3204948d7b73e5386e789661f9198/packages/create-vite/template-lit/package.json#L15