search

bluwy / publint

Lint packaging errors
https://publint.dev
MIT License
960 stars 21 forks source link

"module": true -- crash #73

Closed cameronelliott closed 1 year ago

cameronelliott commented 1 year ago

This is such a needed and cool project!

Ran in to something I wanted to report, inside package.json, if you have:

"module": true, Results in

$ npx publint
node:internal/errors:496
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type boolean (true)
    at new NodeError (node:internal/errors:405:5)
    at validateString (node:internal/validators:162:11)
    at Object.join (node:path:1175:7)
    at Object.pathJoin (file:///Users/c/.npm/_npx/e20844a03f48a51b/node_modules/publint/src/vfs.js:28:23)
    at file:///Users/c/.npm/_npx/e20844a03f48a51b/node_modules/publint/src/index.js:187:30
    at Object.push (file:///Users/c/.npm/_npx/e20844a03f48a51b/node_modules/publint/src/utils.js:297:33)
    at publint (file:///Users/c/.npm/_npx/e20844a03f48a51b/node_modules/publint/src/index.js:186:18)
    at async lintDir (file:///Users/c/.npm/_npx/e20844a03f48a51b/node_modules/publint/lib/cli.js:122:24)
    at async file:///Users/c/.npm/_npx/e20844a03f48a51b/node_modules/publint/lib/cli.js:29:18 {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v20.6.1

Maybe that's ok behavior, but I wanted to show you. (That a real published package with a true, not a string path for module, I am not making this up.)