bluz71 / vim-moonfly-colors

A dark charcoal theme for modern Neovim & classic Vim
MIT License
866 stars 65 forks source link

Add explicit support for 'mini.nvim' #22

Closed echasnovski closed 2 years ago

echasnovski commented 2 years ago

Hi! I would like to add explicit support for mini.nvim.

Basic choices are taken from highlight groups to which 'mini.nvim' makes links by default or from analogous plugins.

Differences from default linked groups:

Before:

https://user-images.githubusercontent.com/24854248/177979652-ab1fbbf7-7cc7-4bb2-93bd-b8e116f0e676.mp4

After:

https://user-images.githubusercontent.com/24854248/177979806-91b0ba69-5f8f-4606-b221-ba87a64882c3.mp4

bluz71 commented 2 years ago

mini.nvim is now supported; some colors have been tweaked from the PR, but most are the same.

When you have time, please test it out and let me know if there are any issues.

Best regards and thanks.

echasnovski commented 2 years ago

Thanks! Everything seems to work as expected.

My notes from 'vim-nightfly-guicolors' PR also apply here.

There is one additional here. Having link ... MoonflyVisual for MiniStatuslineDevinfo and MiniStatuslineFileinfo makes them very similar to MiniStatuslineFilename which goes right next to both of them. Here is a screenshot:

screenshot_2022-07-10_11:14:59

If it is a deliberate decision, I am cool with that. Just noticed this and wanted to point out.

bluz71 commented 2 years ago

MiniJump2dSpot is now underlined.

I think MiniStatuslineDevinfo and MiniStatuslineFileinfo are a mistake on my part. I will revert them, I think you had them as white.

bluz71 commented 2 years ago

Latest commit is fixed MiniStatuslineDevinfo and MiniStatuslineFileinfo.

I think the only outstanding issue relates to tabs, current and visible for both Barbar and Mini tabs?

I will need a day or so to look into this and find a solution. Otherwise I think we are good to go.

Cheers.

echasnovski commented 2 years ago

Yep, everything works great, thanks.

I will need a day or so to look into this and find a solution. Otherwise I think we are good to go.

Agreed. Thanks for looking into this!

bluz71 commented 2 years ago

I think the only outstanding issue relates to tabs, current and visible for both Barbar and Mini tabs?

Should now be fixed.

echasnovski commented 2 years ago

It is indeed. Thanks for deliberate and careful choice of colors!