search

bluz71 / vim-moonfly-colors

A dark charcoal theme for modern Neovim & classic Vim
MIT License
814 stars 65 forks source link

`TODO` word is not visible #28

Closed shayanh closed 2 years ago

shayanh commented 2 years ago

When the cursor is on the same line as the TODO word, TODO becomes too dark and almost impossible to see.

Cursor is one line above the TODO word. TODO is visible. ✅

Screen Shot 2022-09-17 at 4 32 55 PM

Cursor is on the same line as the TODO word. TODO is not visible. ❌

Screen Shot 2022-09-17 at 4 33 09 PM

I'm using moonfly on commit 448df20e1d24cb4d6a32f71de3b1c9d8ea84cbfd, Vim 9.0.50, iTerm2 3.4.16 and macOS 12.6.

bluz71 commented 2 years ago

Thanks for bringing this to my attention.

This issue illustrates a bad interaction between TODO highlighting and cursorline; I don't use cursorline myself hence I did not spot this issue (it's probably been a problem for a long time).

I've now changed to a more subtle TODO highlight style (yellow text instead of a yellow block) that looks better and avoids this issue.

Cheers.

shayanh commented 2 years ago

Thanks for the quick fix!