search

bluz71 / vim-nightfly-colors

A dark midnight theme for modern Neovim & classic Vim
MIT License
819 stars 51 forks source link

icon background are off at places #35

Closed aasutossh closed 2 years ago

aasutossh commented 2 years ago
Screen Shot 2022-09-27 at 13 52 45

for example at the top buffer tabs, the icon background are dark, but at the left file explorer icons are fine.

bluz71 commented 2 years ago

Please provide a minimal Neovim configuration that reproduces the issue.

I suspect you are using the Bufferline plugin? I will endeavour to fix it, if possible; but to be honest that plugin has been a major pain to support.

aasutossh commented 2 years ago

But, how other themes support them well?

bluz71 commented 2 years ago

Certain newer Neovim themes (such a Tokyonight, Catppucin and Nightfox) use very dark tab/statusline with the edit area being lighter. My themes (which are older) use a dark edit area with lighter tab/statusline. This color combination does not work well with bufferline plus I find the bufferline plugin itself is overly complicated.

I wish more folks would just use barbar.nvim instead.

Anyway, provide me a minimal setup and I will see what I can do. I suspect the issue is with NERDFonts and devicons. There probably is a solution for this particular issue.

bluz71 commented 2 years ago

Fixed in the latest commit.

Bufferline requires colorscheme highlight clearing, otherwise highlight groups will be broken (and they were with my theme).

Bufferline also should be allowed to figure out the highlighting itself; it derives a many highlight groups automatically.....these should not be overriden (which I did previously, but no longer do).

Note, the bufferline is quite dark (because my theme itself is quite dark); but that's how it needs to be with this plugin.

Cheers.

aasutossh commented 2 years ago

Excellent work. Thank you.

bluz71 commented 2 years ago

My pleasure. Take care and best regards.