search

bluzi / name-db

:rocket: A multilingual collection of names from around the world
MIT License
59 stars 230 forks source link

Added the name Darshan with all the extras to collection. #506

Closed Darsh2987 closed 6 years ago

Darsh2987 commented 6 years ago

Added the name Darshan with meaning, aliases, translation and sex. :-D

TravisBuddy commented 6 years ago

Build failed

Hey Darsh, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 8

npm test ``` > name-db@1.0.0 test /home/travis/build/bluzi/name-db > mocha name files ✓ should contain valid JSON 1) should contain a lowercase name, same as the filename ✓ should not have duplicate names ✓ should have ISO-639-3 language codes (112ms) ✓ should have correct structure (76ms) Translations ✓ should be lowercase Sex ✓ should be "m", "f" or "u" ✓ should be lowercase 7 passing (269ms) 1 failing 1) name files should contain a lowercase name, same as the filename: AssertionError [ERR_ASSERTION]: name property "Darshan" in "darshan.json" is not lowercase + expected - actual -false +true at Context.it (test/test.js:25:20) npm ERR! Test failed. See above for more details. ```


Darsh2987 commented 6 years ago

Hey, yeah I've fixed the problem.

arminkhoshbin commented 6 years ago

485 Merged. Thanks for your contribution @Darsh2987!