blw-ofag-ufag / eCH-0263

eCH-0263 -- Agrardaten - Betriebsmittel
0 stars 0 forks source link

facilitySpecific should be renamed to allowedForFacilitySpecific #19

Closed montanajava closed 6 months ago

montanajava commented 7 months ago

The attribute name facilitySpecific does not do justice to what this attribute is intended to accomplish.

The practice in the HofRec world is that a metaIngredient (the template upon which a product is ultimately defined) has an intended use, i.e. it is defined up-front whether a farmer can deviate from the template as defined by BLW staff. To accomplish this today in Hoduflu, the attribute allows TRUE | FALSE | BOTH. BOTH means that a metaIngredient can be used for standard products and also for bespoke products defined by a farmer.

BOTH is of course nonsensical but necessary if we in turn have an attribute name that does not represent the actual domain requirements.

As such, to solve the problem, it is recommended that attribute facilitySpecific be called allowedForFacilitySpecific. Doing so allows for a sensible use of TRUE | FALSE as is recommended in https://github.com/blw-ofag-ufag/eCH-0263/issues/18.

anjaaeschlimann commented 7 months ago

ok