search

blynkkk / blynk-library

Blynk library for IoT boards. Works with Arduino, ESP32, ESP8266, Raspberry Pi, Particle, ARM Mbed, etc.
https://blynk.io
MIT License
3.83k stars 1.38k forks source link

Add setMin, setMax methods to Widget objects (set property feature) #396

Closed doom369 closed 6 years ago

doom369 commented 6 years ago

Latest Blynk app supports changing min/max properties for all widget via setProperty functionality. Would be nice to have setMin(float), setMax(float) methods along with setLabel(), setColor().

Doc - http://docs.blynk.cc/#blynk-main-operations-change-widget-properties

cffiebigc commented 6 years ago

Hi, first of all I must say I love Blynk and thank you for making it possible.

I would like to contribute to this library but since I'm pretty much new a the source code I would like to take a small issue like this one to start with. Do you think I can take this one an create a PR to add the described methods? If so please let me know I'll be more than happy to contribute.

doom369 commented 6 years ago

@cffiebigc sure. Just do it :).

cffiebigc commented 6 years ago

Excellent! @doom369 :clap: Do you have more documentation about contributing? like how to run the tests and everything

doom369 commented 6 years ago

Nothing special. Just follow common coding style and that's it.