search

blynkkk / blynk-library

Blynk library for IoT boards. Works with Arduino, ESP32, ESP8266, Raspberry Pi, Particle, ARM Mbed, etc.
https://blynk.io
MIT License
3.83k stars 1.38k forks source link

Changed default behavior #436

Closed mercdev closed 5 years ago

mercdev commented 5 years ago

Description

The default mWeekdays is 1 instead of 0, which causes ALL days to be selected when isWeekdaySelected(n) is used and NO days are selected in the app.

Issues Resolved

Defaults mWeekdays to 0, changing default behavior to what would normally be expected.

vshymanskyy commented 5 years ago

@doom369 Please review the PR and define what would be the correct behavior here

doom369 commented 5 years ago

@vshymanskyy I think yes, but this change requires fix on the app side I think.

vshymanskyy commented 5 years ago

Closed due to inactivity

mercdev commented 5 years ago

:(