Added support for Arduino MKRGSM 1400 - Githubissues

blynkkk / blynk-library

Blynk library for IoT boards. Works with Arduino, ESP32, ESP8266, Raspberry Pi, Particle, ARM Mbed, etc.

https://blynk.io

MIT License

3.83k stars 1.38k forks source link

Added support for Arduino MKRGSM 1400 #443

Closed Rocketct closed 5 years ago

Rocketct commented 5 years ago

hi @vshymanskyy,

Description

Implemented the support file, required to make works Blynk with Arduino MKRGSM 1400:

Implemented the .adapter class;
Implemented the the header file BlynkSimpleMKRGSM.h;
Implemented the example Example/Boards_GSM/Arduino_MKRGSM/Arduino_MKRGSM.ino

Issues Resolved use the native library MKRGSM instead of tinyGSM

Rocketct commented 5 years ago

Hi @vshymanskyy have you any update on this PR and the support for NB1500 one?

vshymanskyy commented 5 years ago

@Rocketct thanks for the PR. Will review this on the weekend!

Rocketct commented 5 years ago

Ok really thank you about your availability @vshymanskyy

Rocketct commented 5 years ago

Hi @vshymanskyy have you find the time to review this and the PR https://github.com/blynkkk/blynk-library/pull/445? i'm sorry for the pressure but i need it soon

vshymanskyy commented 5 years ago

@Rocketct I'm ready to merge these requests. I'm able to validate only the MKR 1400 integration, as I only have this board. I'll merge the MKRNB anyway.

As the PRs are simple enough, we would highly appreciate if Arduino can resign copyrights for #443 and #445 (you can still have the Author signature). If not, it would be easier for us to add this integration and not to deal with legal complications later (having multiple copyright holders).

Rocketct commented 5 years ago

Hi @vshymanskyy yes i'm sorry, i have romeved from both the PRs, thanks

vshymanskyy commented 5 years ago

@Rocketct I have merged the requests, I'll now do some additional tweaks and release the library.

Rocketct commented 5 years ago

ok really thank you.

vshymanskyy commented 5 years ago

@Rocketct done