search

blynkkk / blynk-sketch-generator

This repository is for generating Blynk sketches.
https://examples.blynk.cc
MIT License
25 stars 25 forks source link

All examples for Particle Photon using attachInterrupt will crash #102

Closed jenschr closed 1 year ago

jenschr commented 3 years ago

Kind of depressing letting my students use Blynk with Particle Photon. All examples that use attachInterrupt will fail - ref this forum post from 2015: https://community.blynk.cc/t/email-and-push-notifications-on-particle-photon/2601/3 (yes- the issue still exist. nobody fixed it.

Also as mentioned "digitalPinToInterrupt" does not exist in Particle's API. This is a concious omission in their case since Particle will do this for you autmatically instead, but it should be corrected in the samplecode.

Here is my suggested replacement for the Push Notification example that solves the above two issues: https://go.particle.io/shared_apps/605ba437de63ee0009f529e0

URL to the faulty code: https://examples.blynk.cc/?board=Particle%20Photon&shield=Particle%20WiFi&example=Widgets%2FPushNotification%2FPushNotification_Button

doom369 commented 3 years ago

@vshymanskyy please take a look

vshymanskyy commented 1 year ago

We cannot guarantee that all combinations of all boards/shields/3rd party library versions will work. These are just examples of how it could be used.

jenschr commented 1 year ago

@vshymanskyy So instead of making that simple fix, you'll rather want bad rep for your product? Ok.... I guess? (But it does not make me or others eager to report any other issues)

vshymanskyy commented 1 year ago

it's not a simple fix. unfortunately such a "fix" would break this example for all other platforms/boards. the only thing i can do easily is to remove the example completely.

vshymanskyy commented 1 year ago

Done. This is removed now, the example will disappear with the next update

jenschr commented 1 year ago

I am sorry. I must have misunderstood something here. These examples did all use to be platform specific? If I change things in the menu here https://examples.blynk.cc/?board=Particle%20Photon&shield=Particle%20WiFi&example=Widgets%2FPushNotification%2FPushNotification_Button it will show a different example for "Push Notification Button" for every board. They are unique to each board?

So since they are distinct and per platform, all you'd need to do was to remove "digitalPinToInterrupt" and just hardcode the interrupt to for example D7.

https://docs.particle.io/reference/device-os/api/interrupts/attachinterrupt/

vshymanskyy commented 1 year ago

No, these examples are generated from templates. We don't have a separate example for each of the thousands of different platform/shield/example combinations...

On Thu, 26 Jan 2023, 10:38 am Jens Chr Brynildsen, @.***> wrote:

I am sorry. I must have misunderstood something here. These examples did all use to be platform specific? If I change things in the menu here https://examples.blynk.cc/?board=Particle%20Photon&shield=Particle%20WiFi&example=Widgets%2FPushNotification%2FPushNotification_Button it will show a different example for "Push Notification Button" for every board. They are unique to each board?

So since they are distinct and per platform, all you'd need to do was to remove "digitalPinToInterrupt" and just hardcode the interrupt to for example D7.

— Reply to this email directly, view it on GitHub https://github.com/blynkkk/blynk-sketch-generator/issues/102#issuecomment-1404693935, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALP3FC2UX55ONYGYCMJRXDWUIZXNANCNFSM4ZYBJAWA . You are receiving this because you were mentioned.Message ID: @.***>

jenschr commented 1 year ago

Oh. Quite a few of them have instructions that deviate from the base example, so that was not obvious. I fully agree with your solution then. Better not have it there if it crashes and it's not possible to customize for each platform.