search

blynn / nex

Lexer for Go
http://cs.stanford.edu/~blynn/nex/
GNU General Public License v3.0
416 stars 47 forks source link

update flex simple example link #52

Open denisacostaq opened 5 years ago

denisacostaq commented 5 years ago

flex project has been moved to github: http://flex.sourceforge.net/

purpleidea commented 5 years ago

@denisacostaq If you're going to change the link, ok, but you should reflow to 80 chars.

denisacostaq commented 5 years ago

@denisacostaq If you're going to change the link, ok, but you should reflow to 80 chars.

thankyiu @purpleidea solved in 6fcf2d65665b7ee5cf28d542720b8b9978ee1517

purpleidea commented 5 years ago

@denisacostaq Sorry I should have mentioned it earlier, but the convention is to not break links across lines, so you'll need to fix that, and you can rebase all your commits into a single one and force push.

purpleidea commented 5 years ago

Still not correct, the link is broken, and you want only ONE commit at the end please.

denisacostaq commented 5 years ago

@purpleidea is right now?

purpleidea commented 5 years ago

Almost:

The link should be:

[Foo does not break](URL)

IIRC

Foo

purpleidea commented 5 years ago

bbl

denisacostaq commented 5 years ago

Almost:

The link should be:

[Foo does not break](URL)

IIRC

Foo

@purpleidea the example you shared me [text](url) is how GitHub Flavored Markdown Spec recommend, but if you look in the org REAME you can find this for example:

== Toy Pascal ==

The Flex manual also exhibits a http://flex.sourceforge.net/manual/Simple-Examples.html[scanner for a toy Pascal-like language],
though last I checked, its comment regex was a little buggy. Here is a

and I want to be consitent with this, I think the [] can be breake in multplie lines because it is not the link at all, but if you prefer this way you can fix this, including to fix the new link I am pointing in the pr and close this