search

bm1549 / home-assistant-frigidaire

Custom component for the Frigidaire integration
30 stars 10 forks source link

Most Recent Commit (09/05/2021) causing AC to be "Unavailable" #13

Closed glnces closed 2 years ago

glnces commented 2 years ago

Hey there! After installing this integration and playing around I found that the most recent commit 306ea32ee59fc0aef4fa9f7e7d889b0e5e76b9e0 will discover my AC units, but will list them as "Unavailable" in Home Assistant. I instead checked out an earlier commit 84a91c585f6bd89171c2d0be3b1f30d3c2d19f50 and it's working fine. Just wanted to give a heads up.

bm1549 commented 2 years ago

@attempted I'm not near my laptop, but if you can put up a fix in a PR I'd be happy to approve/merge it!

gazpachoking commented 2 years ago

Sorry guys, I probably messed the unavailable stuff up. I'll take a peek unless someone gets to it first.

On Mon, Sep 13, 2021 at 4:49 PM Brian Marks @.***> wrote:

@attempted https://github.com/attempted I'm not near my laptop, but if you can put up a fix in a PR I'd be happy to approve/merge it!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bm1549/home-assistant-frigidaire/issues/13#issuecomment-918564562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABNV7IXCUEIRC2Q6QP7IG3UBZPWLANCNFSM5D6UPHSQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

fiveball02 commented 2 years ago

Just cloned the repo and can confirm that it is working correctly now. Thanks.

bm1549 commented 2 years ago

Fixed in #14