search

bm1549 / home-assistant-frigidaire

Custom component for the Frigidaire integration
30 stars 10 forks source link

Uses "frigidaire" package which always connect to LATAM Region - Should use "pyelectroluxconnect" Instead #27

Closed indomitableMan closed 2 weeks ago

indomitableMan commented 1 year ago

This code has a couple of issues related to connecting to Electrolux which owns the Frigidaire brand:

In the manifest.json file there is a hard coded dependency - "frigidaire==0.18.11" that should be changed to "frigidaire>=0.18.11" since the current version of the "frigidaire" package is 0.18.12. Without this change, the integration will not bring up the configuration screen asking for the username and password to connect to the Frigidaire API.

An even bigger issue that this the "frigidaire" package always connects to the same API URL (https://api.latam.ecp.electrolux.com) which is for the Latin America region. Electrolux runs API servers in multiple regions of the world and each has a unique URL. The Python package "pyelectroluxconnect" takes this into consideration and provides a "region" parameter which can be set during the initial connection to the Electrolux API server.

I would respectfully suggest changing out the "frigidaire" package for the "pyelectroluxconnect" connect package since it appears to be more fully featured and functional across different regions.

indomitableMan commented 1 year ago

created a separate fork with updates to const.py to support eventual migration to pyelectroluxconnect package.

bm1549 commented 1 year ago

I'm happy to accept a PR if you're willing to make the required updates!