search

bmad-sim / AtomicAndPhysicalConstants.jl

Julia package for handling particle identification in simulations.
MIT License
0 stars 1 forks source link

created getMasses function #10

Closed lllx125 closed 6 months ago

lllx125 commented 6 months ago

I wrote the getMasses function. The specification is in the code, I am not sure whether pion+ and pion- have the same mass because I can only find pion+- in the data.

DavidSagan commented 6 months ago

@lllx125 Yes both pions have the same mass.

rot4te commented 6 months ago

Lixing, I sent an email to you just now, but please add a factor of 10^6 to your result, such that the unit base is eV rather than MeV. Thanks!

lllx125 commented 6 months ago

The unit is changed to eV

mattsignorelli commented 6 months ago

Following the style guide here, I think the function should have the name getmasses instead of getMasses

DavidSagan commented 6 months ago

I find getmasses a bit too generic. How about download_pdg_masses

rot4te commented 6 months ago

I'm thinking about pulling some anomalous magnetic moments from PDG as well, so for specificity pdg_pion_masses could be good as well

lllx125 commented 6 months ago

I rename the function

DavidSagan commented 6 months ago

I like "download" in the name since it is descriptive. What do others think?

mattsignorelli commented 6 months ago

I agree with keeping “download” in the name, as it’s much more descriptiveOn Mar 13, 2024, at 5:43 PM, David Sagan @.***> wrote: I like "download" in the name since it is descriptive. What do others think?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

lllx125 commented 6 months ago

I rename the function