search

bmad-sim / AtomicAndPhysicalConstants.jl

Julia package for handling particle identification in simulations.
https://bmad-sim.github.io/AtomicAndPhysicalConstants.jl/dev
MIT License
0 stars 0 forks source link

Formalize PR procedure. #49

Open DavidSagan opened 1 month ago

DavidSagan commented 1 month ago

There needs to be some guidelines for how to handle PRs. How are reviewers assigned (the PR person assigns reviewers?) and who should be responsible for merging the PR (The PR person after the reviewers are finished?) are two.

rot4te commented 3 weeks ago

Following my email a few minutes ago, I think the most important part of this is editing the CI workflow. If you've done your work in a new branch (eg after a git checkout -b new_issue), then you can push to the branch with git push -u origin new_issue, and it will run the CI. If the CI is modified with the intended functionality of the new code in mind, a passing score could let us automatically merge.

DavidSagan commented 3 weeks ago

Just passing CI tests is not always enough. Especially if the person submitting the PR is inexperienced. We should have a discussion about this...