consider using renaming `massof` to `mass`, etc.

[DavidSagan]

I propose the following name changes:

• massof() -> mass()
• chargeof() -> charge()
• setunits(mass_unit, length_unit, time_unit, energy_unit, charge_unit) -> setunits(mass, length, time, energy, charge)

Any thoughts, comments?

[mattsignorelli]

Shouldn't the Species struct just store the mass, etc in the chosen units? It seems weird that we have calculate on the fly all of these units?

[DavidSagan]

But how to handle if a Species instance is created with one set of units and code using a different set of units tries to get the mass?

[mattsignorelli]

Ah, right, that makes sense

[DavidSagan]

Shall I close this issue?

[mattsignorelli]

Are the name changes pushed?

[DavidSagan]

Sorry I was confused. Ignore my last post.

[dtabell]

My only suggestion would be to reorder the arguments of setunits to (mass, length, time, charge, energy).

Dan

On Thu, Sep 26, 2024 at 16:46 David Sagan @.***> wrote:

I propose the following name changes:

• massof() -> mass()
• chargeof() -> charge()
• setunits(mass_unit, length_unit, time_unit, energy_unit, charge_unit) -> setunits(mass, length, time, energy, charge)

Any thoughts, comments?

— Reply to this email directly, view it on GitHub https://github.com/bmad-sim/AtomicAndPhysicalConstants.jl/issues/68, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXTUHE4FOOQW5ZXE644BNTZYSFEZAVCNFSM6AAAAABO57QQIGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2TCNRVGQ2DQMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[lllx125]

I think setunits(mass, length, time, charge, energy) is more consise

[DavidSagan]

OK so anyone feel free to make this change.

[lllx125]

changed massof()->mass, chargeof()->charge(), the stunt parameter are unchanged.