bmad-sim / NonlinearNormalForm.jl

Nonlinear normal form analysis using truncated power series
https://bmad-sim.github.io/NonlinearNormalForm.jl/
GNU General Public License v3.0
1 stars 0 forks source link

fix `outx_low` inv_work_low temporary #13

Closed mattsignorelli closed 5 months ago

mattsignorelli commented 5 months ago

Because of of the bug in GTPSA, the output map length must be nn and not nv. Therefore this temporary is unnecessarily big.

After the bug is fixed the affected functions inv!, prep_comp_inv_work_low and prep_inv_work_low should be corrected. Also instead of allocating a new array for the quaternion if nv<4 instead of reusing m1x_low or whatever it was, instead just make m1x_low big enough to reuse quaternion part

mattsignorelli commented 5 months ago

This appears to not be a bug in GTPSA