REF/CLN: switch to pyproject.toml, setuptools-scm and clean codebase

ken-lauer commented 1 week ago

Description

Moved from setup.py to pyproject.toml
Moved from versioneer to setuptools-scm
Bumped minimum Python version to 3.9 (not quite NEP-29)
Bumps minimum bmad version for passing tests
Used previously-added pre-commit settings to reformat and lint the entire codebase. I picked 95 characters as a seemingly reasonable value for the really really long lines in pytao.gui.
Fixed up issues as found by the linter, some automatically and some manually
Some were previously untested and clearly not functional (code paths not hit in the GUI)
Removed all instances of star imports
Added a simple test to ensure that at least the GUI can be imported
Fixes plotting after key update (https://github.com/bmad-sim/bmad-ecosystem/issues/1018#event-13305400220)
Fixes unnecessary environment variable requirement when using ctypes backend in the GUI (ACC_EXE can now be unset)
Fixes reliance on deprecated matplotlib rcParam key
Adds pytao and pytao-gui entrypoints

Usage

Start pytao's GUI from the command-line with:

$ pytao-gui -init tao.init

Start a quick pytao session with IPython using:

$ pytao -init tao.init
------------------------------------------------------------
Initializing `tao` object with the following: -init tao.init
Type`tao.` and hit tab to see available commands.
------------------------------------------------------------

Python 3.12.0 | packaged by conda-forge | (main, Oct  3 2023, 08:36:57) [Clang 15.0.7 ]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.18.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: tao
Out[1]: <pytao.interface_commands.Tao at 0x13c43d4f0>

To the reviewers

I wouldn't recommend looking at the full diff to avoid the reformatting commits. Take a look commit-by-commit for some of the syntax fixes, and then just the new files for pyproject.toml migration

ken-lauer commented 1 week ago

Tests are failing locally and on GHA due to an upstream change that I think was incorrect:

FAILED pytao/tests/test_interface_commands.py::test_ele_photon_1[Tao] - ValueError: Unknown bool: Not_set
FAILED pytao/tests/test_interface_commands.py::test_ele_photon_1[SubprocessTao] - ValueError: Unknown bool: Not_set

https://github.com/bmad-sim/bmad-ecosystem/issues/1026#issuecomment-2197331632

Pending: https://github.com/conda-forge/bmad-feedstock/pull/421

ChristopherMayes commented 6 days ago

FODO notebook should be fixed in master.

hhslepicka commented 4 days ago

Thanks for the heads up about looking at the commits, not the diff! 😄

bmad-sim / pytao