bmag / emacs-purpose

Manage Windows and Buffers According to Purposes
GNU General Public License v3.0
494 stars 22 forks source link

Fix CI: don't fail fast, and really allow failure on emacs-snapshot #183

Closed bmag closed 3 years ago

bmag commented 3 years ago

Before, any failure, even against emacs-snapshot, would cancel all remaining jobs and mark the test ("workflow") as failed. This PR it partially.

Sometimes we need to compare between Emacs versions. With fail-fast set to true (the default), failure in one Emacs version cancels the remaining jobs for other Emacs versions. That's why we now set fail-fast to false.

Additionally, allow_failures from Travis CI is called continue-on-error in Github Actions.

Situation before:

Situation after:

This PR seems to fix the CI and the pass/fail marks as much as possible on our side. The remaining misleading red "x" mark is a bug in Github's interface (see https://github.com/actions/runner/issues/2347) .