bmak91 / fcm-push-notification

FCM Push Notifications Service for ASP.Net Core MVC
MIT License
5 stars 5 forks source link

Rename proposal #3

Open AndrewBoklashko opened 6 years ago

AndrewBoklashko commented 6 years ago

When using such libraries it is common to have a wrapper around library service that will care about notification templates, error handling or additional logic that could be required by particular application. In my case I would like to create IPushNotificationService that will wrap you library service, but I cant do that because your library expose such interface. I was thinking about other names for my service but couldn't find anything enough verbose and precise.

So I would propose to rename IPushNotificationService to something more related to your library, like IFCMPushNotificationService.

bmak91 commented 6 years ago

I see your point and will consider that going forward, but this would be a breaking change so I won't do it for now (possibly reserved till version 2.x)

Meanwhile creating your own IPushNotificationService that inherits from the one provided by the library should still be possible:

public interface IPushNotificationService : ACB.FCMPushNotifications.IPushNotificationService

and if needed:

using IPushNotificationService = MyProject.IPushNotificationService;