(restricted) Workspace Trust support

bmalehorn / vscode-fish

Fish syntax highlighting and formatting

MIT License

62 stars 6 forks source link

(restricted) Workspace Trust support #24

Closed dgcampea closed 2 years ago

dgcampea commented 2 years ago

Currently vscode-fish is fully disabled when operating in Restricted Mode. Can "limited" mode be implemented for at least syntax highlighting and extension association to work?

Links (for reference):

https://code.visualstudio.com/docs/editor/workspace-trust
https://code.visualstudio.com/api/extension-guides/workspace-trust

bmalehorn commented 2 years ago

Sounds simple enough, this might be just a 1-line change.

@dgcampea do you have a good way of reproducing this issue? How can I open a workspace in restricted mode so I can see this issue?

dgcampea commented 2 years ago

Open Folder should be enough to trigger a message box that asks for mode selection.

bmalehorn commented 2 years ago

@dgcampea I updated it to have limited access, so it now highlights in restricted mode:

before:

after:

Does it look good from your end?

bmalehorn commented 2 years ago

Closing out this issue as resolved.