search

bmalehorn / vscode-fish

Fish syntax highlighting and formatting
MIT License
65 stars 7 forks source link

Exclude images from extension package #30

Closed kidonng closed 2 years ago

kidonng commented 2 years ago

First of all, thanks for this awesome extension! I noticed some large images are not excluded in the extension package, hence this pull request.

With the images excluded, the package size goes from 2.3MB down to just 59.27KB! It does not break the links as VSCode rewrites assets in README to use GitHub links.

bmalehorn commented 2 years ago

Thanks @kidonng ! I had no idea these images were being included, glad to have them removed.

On a related note how are you viewing the extension package size?

kidonng commented 2 years ago

On a related note how are you viewing the extension package size?

When you do vsce package it will output size info.

bmalehorn commented 2 years ago

Thanks. I've now published a new image with the reduced image size.