bmalehorn / vscode-fish

Fish syntax highlighting and formatting
MIT License
65 stars 7 forks source link

No syntax highlighting for in-string command substitution #32

Open KevinMGranger opened 1 year ago

KevinMGranger commented 1 year ago
set variable "$(some-command)/path"

In the above, it would be cool if $(some-command) were highlighted differently than the rest of the string.

Edit: heh, even github's syntax highlighting doesn't handle it 😅

bmalehorn commented 1 year ago

@KevinMGranger Thanks for the suggestion! I'll have to look into how other languages implement this, maybe the ruby language, which works without a language server.

All of the syntax highlighting is in this file: https://github.com/bmalehorn/vscode-fish/blob/master/syntaxes/fish.tmLanguage.json

However it's entirely regex-based (as most languages are), which doesn't lend itself well to nested code like this.