bmalehorn / vscode-fish

Fish syntax highlighting and formatting
MIT License
62 stars 6 forks source link

Four backslashes break syntax highlighting #5

Closed exploide closed 4 years ago

exploide commented 4 years ago

The following snippet breaks the syntax highlighting since the closing single-quote is erroneously treated as being escaped.

set backslash '\\\\'
set foo "broken highlighting"

fish-backslash

(Apparently this is also true for GitHub's highlighting)

bmalehorn commented 4 years ago

Thanks for the report! I've fixed this and pushed out an update.

I'm not super surprised GitHub's syntax highlighting is wrong too. This extension's syntax highlighting was copied from another VSCode extension, which was copied from an Atom extension, which itself was copied from the Sublime extension. It's kind of been passed around forever and rarely scrutinized, I'd bet GitHub's comes from the same buggy lineage.