search

bmaltais / kohya_ss

Apache License 2.0
9.57k stars 1.23k forks source link

Can't set custom caption file extention #2412

Open ddpasa opened 6 months ago

ddpasa commented 6 months ago

In the past the UI allowed us to set any file extention for the caption files. Now it's a dropdown box with just 3 options. Please restore the older flexibility, it was much nicer. For example, I have captions generated by multiple algorithms (wd14, blip, llava, moondream...) and being able to alternate between them by changing the extention in the config is very powerful.

bmaltais commented 6 months ago

In the past the UI allowed us to set any file extention for the caption files. Now it's a dropdown box with just 3 options. Please restore the older flexibility, it was much nicer. For example, I have captions generated by multiple algorithms (wd14, blip, llava, moondream...) and being able to alternate between them by changing the extention in the config is very powerful.

I had to set this like that to limit the risk of hijack as reported in the security report I received... but I could update the interface to accept custom values... maybe this is an acceptable trade since I moved to use non-shell based subprocess...

bmaltais commented 6 months ago

I have allowed the use of custom caption extension in the dev branch. Give it a try and let me know if it work fine for you. THis was added as part of a larger change that switch everything to use more secure shell-False for all scripts... Hoping the full package does not cause any issues.