search

bmaltais / kohya_ss

Apache License 2.0
9.42k stars 1.22k forks source link

bug in apply settings Noise offset type #2599

Open oO0 opened 3 months ago

oO0 commented 3 months ago

1. set "noise_offset_type": "Multires", set "multires_noise_discount": 0.8,

See training failed (overtrainig). stop (or load setting)

4. set "noise_offset_type": "Original",

5. it continue use "multires_noise_discount": 0.8, and fail all next work until manually set it to 0

It is wrong behavior or wrong UIX practice. after set Noise offset type = ORIGINAL values from 'multires' should not affect training

And i think "multires_noise_discount": 0.8, should not be recommended value as it seems very-very high for any dataset i tested (up to 1000 pic)

And near to it is another bug: loading Adaptive noise scale from file not update GUI https://github.com/bmaltais/kohya_ss/issues/2600

bmaltais commented 3 months ago

Thank you for the report. I will investigate why that is today. Hopefully I will be able to push a fix to the dev branch soon.

bmaltais commented 3 months ago

OK, so switching the Noise Offset Type does result in the right parameter for it to be passed in the .toml values... BUT... the gui, at the moment, does not filter out unrelated values for noise offset parameters that are not pertinent to the selected noise offset type... and this might be throwing the trainer off... I will see if I can add some kind of logic to only set the noise offset values that are supported be the offset type in the toml...

bmaltais commented 3 months ago

OK, This issue should be fixed now in the dev branch. Give it a try.