bman46 / InstagramEmbedDiscordBot

Embeds videos and images from an Instagram link into a Discord chat.
BSD 3-Clause "New" or "Revised" License
77 stars 26 forks source link

Prevent double embed #13

Closed gazpachoking closed 2 years ago

gazpachoking commented 2 years ago

Sometimes, the default discord embedding decides to work, and in these cases we get two embeds for that link, one default and one from this bot. Is there a good way to prevent this?

bman46 commented 2 years ago

The bot used to be able to do this automatically but unfortunately Discord.net removed the method that I used to remove embeds and I haven't found a new way to do it yet.

bman46 commented 2 years ago

Also, if you put the link between < and > like so: <https://instagram.com/> discord will not embed its contents. I know that it is not optimal and i will try to find an automatic solution but that is a workaround for now.

bman46 commented 2 years ago

https://github.com/discord-net/Discord.Net/issues/2020

gazpachoking commented 2 years ago

Cool, thanks for the info. Hopefully they'll bring that feature back. 😃

gazpachoking commented 2 years ago

😄🥳

bman46 commented 2 years ago

Just released the fix to the main bot! Let me know if you notice any other issues. Thanks for reporting this.

gazpachoking commented 2 years ago

Do we have to do anything special to enabled this? We are still getting double embeds. 🙁 image

bman46 commented 2 years ago

The bot must have manage messages permission to remove them.

On Jan 11, 2022, at 2:25 PM, Chase Sterling @.***> wrote:

Do we have to do anything special to enabled this? We are still getting double embeds. 🙁 https://user-images.githubusercontent.com/187133/149008080-c4b58edd-7a20-43b9-9eb3-94ceae1799e6.png — Reply to this email directly, view it on GitHub https://github.com/bman46/InstagramEmbedDiscordBot/issues/13#issuecomment-1010288406, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQAZR52XBJYYR5MMB7B5Y3UVR73HANCNFSM5LPBYGNA. You are receiving this because you modified the open/close state.

gazpachoking commented 2 years ago

Doh! Of course! Thanks!

bman46 commented 2 years ago

No problem