search

bman46 / InstagramEmbedDiscordBot

Embeds videos and images from an Instagram link into a Discord chat.
BSD 3-Clause "New" or "Revised" License
75 stars 25 forks source link

Add support for spoilers in text commands #87

Open dy-lin opened 1 year ago

dy-lin commented 1 year ago

I'd like support for spoilers when using text commands just as is available with slash commands.

By updating the prefix to include the two pipes, the bot still recognizes the instagram link. 

 "Prefix": [ "https://www.instagram.com/", "https://instagram.com/", "http://www.instagram.com/", "http://instagram.com/", "||https://instagram.com/", "|| https://instagram.com/"  ]

The bot could register that the prefix contains pipes and use the isSpoiler parameter in FileAttachment (like with the slash commands).

It appears the infrastructure is already present, and just needs to detect whether the text command or prefix contains pipes and adjust accordingly.

bman46 commented 1 year ago

It's certainly feasible to do. What is your use case for this though? I would think that it would be easier and more user friendly to use the slash command to do this.

dy-lin commented 1 year ago

I mostly use Discord on mobile and find slash commands clunky to use since you have to select each parameter.

bman46 commented 1 year ago

Ok, makes sense. For now, I am prioritizing #85 but after that I should be able to get around to it as the changes required should not be too complex.