search

bmarcot / vega

vega -- The Unix-like Operating System for micro-controllers (ARM Cortex-M4)
6 stars 1 forks source link

ffs/ffz are wrong #19

Closed bmarcot closed 7 years ago

bmarcot commented 7 years ago

Return value is wrong. See http://pubs.opengroup.org/onlinepubs/009695399/functions/ffs.html for correct return values.

Use __builtin_ffs and __builtin_ffz.

Also, see http://lxr.free-electrons.com/source/arch/arm/include/asm/bitops.h

bmarcot commented 7 years ago

Fixed in 0f94fdc8cd51a205b07eb3017e9576687de14cad