Relax rack version requirement

bmarini / knife-inspect

Inspect your chef repo as is compares to what is on your chef server

MIT License

55 stars 13 forks source link

Relax rack version requirement #49

Closed jonlives closed 7 years ago

jonlives commented 7 years ago

This requirement stops knife-inspect working on the most recent chef-client omnibus installs, and as far as I can tell relaxing it doesn't break anything...

coveralls commented 7 years ago

Coverage remained the same at 75.248% when pulling 10fb73b53737621c6ad984da73e4c9de06fb5812 on jonlives:master into 9cf42f1165f56b67f1a32eb4265f437bbdea26f6 on bmarini:master.

jonlives commented 7 years ago

I don't think the failing checks were due to this PR - looks like some other gem resolution issues :)

gregkare commented 7 years ago

Thanks, I'll take a look at this soon. In fact I don't even know why there's an explicit dependency on rack

jonlives commented 7 years ago

Thanks - I did wonder about that, but I needed to fix this more quickly than I needed to figure out that :D

gregkare commented 7 years ago

@jonlives Thanks for letting me know about this issue. I went with removing the dependency. I have published 0.16.0, let me know if that doesn't work

jonlives commented 7 years ago

Yesss, thanks for the quick turnaround!!