search

bmarrdev / android-DecoView-charting

DecoView: Android arc based animated charting library
Apache License 2.0
991 stars 194 forks source link

Multiple quality improvements #17

Closed m-ezzat closed 8 years ago

m-ezzat commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S2974 - Classes without "public" constructors should be "final" squid:S00116 - Field names should comply with a naming convention squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause

You can find more information about the issues here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S2974 https://dev.eclipse.org/sonar/coding_rules#q=squid:S00116 https://dev.eclipse.org/sonar/coding_rules#q=squid:SwitchLastCaseIsDefaultCheck

Please let me know if you have any questions.

M-Ezzat

m-ezzat commented 8 years ago

I am not sure whether you do not agree with these changes or not. Please close this PR if not.