search

bmartin5692 / bumper

A standalone and self-hosted implementation of the central server used by Ecovacs vacuum robots.
GNU General Public License v3.0
286 stars 48 forks source link

Ensure all bots are returned during getProductIotMap #70

Closed aharter closed 4 years ago

aharter commented 4 years ago

Fixes #69. Based on the list in the handler, I wrote a filter function for the EcoVacsHomeProducts list. Basically removing supportType from the items. After double checking with the captured traffic I created for myself, I realized the payload actually contains supportType. Therefore, using EcoVacsHomeProducts is just fine. However, I am not sure which impact it has on the DEEBOT 2017 app. Probably none.

codecov[bot] commented 4 years ago

Codecov Report

Merging #70 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files          13       13           
  Lines        2856     2856           
=======================================
  Hits         2536     2536           
  Misses        320      320
Impacted Files Coverage Δ
bumper/confserver.py 73.07% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97a5365...707a114. Read the comment docs.